Fix graphite2 intermediate output path#785
Merged
johnml1135 merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the native graphite2 intermediate output base path so native intermediates land under the repo-local Obj tree rather than a sibling directory.
Changes:
- Add the missing path separator after
$(fwrt)inNativeIntDirBaseto correctly point under$(fwrt)\Obj\...
jasonleenaylor
approved these changes
Mar 25, 2026
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on johnml1135).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the native graphite2 intermediate output base path in
Build/Windows.targetsby adding the missing path separator after$(fwrt).Problem
NativeIntDirBasewas defined as$(fwrt)Obj\$(config-capital)\, which expands to a sibling folder such asFieldWorksObj\Debug\graphite2instead of the intended repo-local pathFieldWorks\Obj\Debug\graphite2.This only affected graphite2 because it is the only consumer of
NativeIntDirBase.Why this matters
Writing graphite2 intermediates outside the repository
Objtree can leave stale graphite outputs behind:FieldWorks\ObjFieldWorksObjfolder are easy to miss during normal cleanupChange
Update
NativeIntDirBaseto use:Validation
./build.ps1CI: Commit messagesCI: Whitespace checkThis change is